gtkwidget: Do not listen to notifications from nonexistent properties
authorCarlos Garnacho <carlosg@gnome.org>
Mon, 14 Sep 2015 15:33:23 +0000 (17:33 +0200)
committerCarlos Garnacho <carlosg@gnome.org>
Mon, 14 Sep 2015 15:39:41 +0000 (17:39 +0200)
The GtkEventController event mask is private, and set early by GtkGesture
implementations. Being this private data, there is no corresponding
property, so this code is a no-op, there is just no need to listen to
changes there.

gtk/gtkwidget.c

index 17cd274e78d423348e525b850bd56ef812a55238..7f39e354252750ac45cb801f8912ff247712ec49 100644 (file)
@@ -478,7 +478,6 @@ typedef struct {
 
 typedef struct {
   GtkEventController *controller;
-  guint evmask_notify_id;
   guint grab_notify_id;
   guint sequence_state_changed_id;
 } EventControllerData;
@@ -17113,14 +17112,6 @@ _gtk_widget_update_evmask (GtkWidget *widget)
     }
 }
 
-static void
-event_controller_notify_event_mask (GtkEventController *controller,
-                                    GParamSpec         *pspec,
-                                    GtkWidget          *widget)
-{
-  _gtk_widget_update_evmask (widget);
-}
-
 static void
 event_controller_sequence_state_changed (GtkGesture            *gesture,
                                          GdkEventSequence      *sequence,
@@ -17186,9 +17177,6 @@ _gtk_widget_add_controller (GtkWidget          *widget,
 
   data = g_new0 (EventControllerData, 1);
   data->controller = controller;
-  data->evmask_notify_id =
-    g_signal_connect (controller, "notify::event-mask",
-                      G_CALLBACK (event_controller_notify_event_mask), widget);
   data->grab_notify_id =
     g_signal_connect (widget, "grab-notify",
                       G_CALLBACK (event_controller_grab_notify), data);
@@ -17226,7 +17214,6 @@ _gtk_widget_remove_controller (GtkWidget          *widget,
   if (g_signal_handler_is_connected (widget, data->grab_notify_id))
     g_signal_handler_disconnect (widget, data->grab_notify_id);
 
-  g_signal_handler_disconnect (data->controller, data->evmask_notify_id);
   g_signal_handler_disconnect (data->controller, data->sequence_state_changed_id);
   data->controller = NULL;
 }